Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cscli: refactor "cscli setup" to avoid global variable #3075

Merged
merged 5 commits into from
Jun 12, 2024
Merged

cscli: refactor "cscli setup" to avoid global variable #3075

merged 5 commits into from
Jun 12, 2024

Conversation

mmetc
Copy link
Contributor

@mmetc mmetc commented Jun 10, 2024

No description provided.

@github-actions GitHub Actions
Copy link

@mmetc: There are no 'kind' label on this PR. You need a 'kind' label to generate the release automatically.

  • /kind feature
  • /kind enhancement
  • /kind refactoring
  • /kind fix
  • /kind chore
  • /kind dependencies
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

@github-actions GitHub Actions
Copy link

@mmetc: There are no area labels on this PR. You can add as many areas as you see fit.

  • /area agent
  • /area local-api
  • /area cscli
  • /area appsec
  • /area security
  • /area configuration
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

@mmetc mmetc changed the title cCscli csconfig cscli: refactor "cscli setup" to avoid global variable Jun 10, 2024
@mmetc mmetc added this to the 1.6.3 milestone Jun 10, 2024
@codecov Codecov
Copy link

codecov bot commented Jun 10, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 71.15385% with 30 lines in your changes missing coverage. Please review.

Project coverage is 52.55%. Comparing base (bd4540b) to head (b3910ce).

Files Patch % Lines
pkg/setup/install.go 46.34% 22 Missing ⚠️
cmd/crowdsec-cli/setup.go 87.30% 7 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #3075      +/-   ##
==========================================
+ Coverage   52.49%   52.55%   +0.06%     
==========================================
  Files         281      281              
  Lines       35435    35383      -52     
==========================================
- Hits        18602    18596       -6     
+ Misses      15011    14974      -37     
+ Partials     1822     1813       -9
Flag Coverage Δ
bats 40.26% <78.72%> (-0.01%) ⬇️
unit-linux 34.86% <0.00%> (+0.03%) ⬆️
unit-windows 31.01% <0.00%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mmetc mmetc requested a review from sabban June 11, 2024 10:29
sabban
sabban approved these changes Jun 12, 2024
View reviewed changes
Copy link
Contributor

@sabban sabban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mmetc mmetc merged commit fd433a7 into master Jun 12, 2024
17 checks passed
@mmetc mmetc deleted the cscli-csconfig branch June 12, 2024 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sabban sabban sabban approved these changes

Assignees
No one assigned
Labels
kind/refactoring needs/area
Projects
None yet
Milestone
1.6.3
Development

Successfully merging this pull request may close these issues.
2 participants
@mmetc @sabban